fix(scalasdk): fix passivation strategy.#492
Merged
RayRoestenburg merged 1 commit intomainfrom Sep 24, 2021
Merged
Conversation
RayRoestenburg
force-pushed
the
fix_passivation_strategy
branch
from
d2db54f to
d97bc9b
Compare
patriknw
approved these changes
Sep 24, 2021
Contributor
patriknw
left a comment
patriknw
left a comment
There was a problem hiding this comment.
LGTM, after one small cleanup
| case com.akkaserverless.scalasdk.impl.Timeout(None) => javasdk.PassivationStrategy.defaultTimeout() | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
at the top of the file, remove
import com.akkaserverless.javasdk.impl.Timeout
so that we always reference javasdk classes more explicitly here, like: javasdk.impl.Timeout
RayRoestenburg
force-pushed
the
fix_passivation_strategy
branch
from
d97bc9b to
162f50e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.