Skip to content

chore(scalasdk): codegenScala sbt project#485

Merged
raboof merged 1 commit intomainfrom
wip-codegenScala-patriknw
Sep 24, 2021
Merged

chore(scalasdk): codegenScala sbt project#485
raboof merged 1 commit intomainfrom
wip-codegenScala-patriknw

Conversation

@patriknw
Copy link
Copy Markdown
Contributor

  • similar to codegenJava
  • annoying that they have different naming conventions

tab completion:

sbt:akkaserverless-java-sdk> codegen
codegenCore/                  codegenJava/                  codegenJavaCompilationTest/   codegenScala/

Copy link
Copy Markdown
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to align.

I think I prefer having the sbt project id the same as the artifact name, so I'd maybe rather change things the 'other way around' - but this is OK

@patriknw
Copy link
Copy Markdown
Contributor Author

I think I prefer having the sbt project id the same as the artifact name

Personally I agree, but I thought I'd just follow the style that existed

@johanandren
Copy link
Copy Markdown
Contributor

+1 on following artifact names (but I think it might interfere with how @RayRoestenburg s dev env is set up?)

@RayRoestenburg
Copy link
Copy Markdown
Contributor

I can do something temporarily, or fix sbt-sublime, which is so old, I should probably rip off the band-aid :-) so do what is best.

* similar to codegenJava
* annoying that they have different naming conventions
@patriknw patriknw force-pushed the wip-codegenScala-patriknw branch from 4195f91 to ce782fa Compare September 24, 2021 08:08
@patriknw
Copy link
Copy Markdown
Contributor Author

Could we merge this as a first sanity and do a bigger build refactoring later if we feel that is important?

@raboof
Copy link
Copy Markdown
Contributor

raboof commented Sep 24, 2021

(ah I didn't realize the package names were interfering with sbt-sublime)

@RayRoestenburg
Copy link
Copy Markdown
Contributor

They don't, it is actually the name of the project variables, (It does not support identifiers in backticks) so this is not an issue.

@RayRoestenburg
Copy link
Copy Markdown
Contributor

@raboof this #408 was what caused an issue for sbt-sublime, FYI.

@raboof raboof merged commit 1e7cc91 into main Sep 24, 2021
@raboof raboof deleted the wip-codegenScala-patriknw branch September 24, 2021 08:32
raboof pushed a commit that referenced this pull request Sep 24, 2021
* similar to codegenJava
* annoying that they have different naming conventions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants