chore(codegen): always choose between Java- and Scala testdata#481
Merged
octonato merged 1 commit intolightbend:mainfrom Sep 23, 2021
Merged
chore(codegen): always choose between Java- and Scala testdata#481octonato merged 1 commit intolightbend:mainfrom
octonato merged 1 commit intolightbend:mainfrom
Conversation
patriknw
approved these changes
Sep 23, 2021
Contributor
patriknw
left a comment
patriknw
left a comment
There was a problem hiding this comment.
LGTM, great to make these cleanups now, before we duplicate to event sourced and replicated entities
octonato
approved these changes
Sep 23, 2021
| | | ||
| | override final def additionalDescriptors: immutable.Seq[Descriptors.FileDescriptor] = | ||
| | ${service.fqn.parent.name}Proto.javaDescriptor :: | ||
| | ${typeName(service.descriptorObject)}.javaDescriptor :: |
Member
There was a problem hiding this comment.
I think I just fixed this and is merged already.
Contributor
Author
There was a problem hiding this comment.
you might be thinking of #475 (comment) , which seems to be failing that PR and motivated me to do this cleanup :)
raboof
force-pushed
the
testdata-variants
branch
from
a372163 to
b760b24
Compare
Member
|
If I didn't say it before, here it is. I find that the codegen is getting neater each day. I like the introduction of the methods generateManaged, generateUnmanaged and generateManagedTest. Also the fact that we are improving the model and not copying past or doing too many low level data manipulations all over the place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.