fix: remove warning on additionalDescriptors#472
Merged
Conversation
octonato
commented
Sep 23, 2021
|
|
||
| def newHandler(context: ViewCreationContext): ViewHandler[S, V] | ||
|
|
||
| def additionalDescriptors(): immutable.Seq[Descriptors.FileDescriptor] |
Member
Author
There was a problem hiding this comment.
the generated code doesn't use () and we get a warning on compilation. Since it's Scala, we can remove the it. This aligns with serviceDescriptor a few lines above.
raboof
approved these changes
Sep 23, 2021
octonato
force-pushed
the
rgc/remove-warning-on-additionalDescriptors
branch
from
3d6ce36 to
e74be09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.