fix(sbt-plugin): make sure akkaserverless classes are generated#460
Merged
octonato merged 1 commit intolightbend:mainfrom Sep 22, 2021
Merged
Conversation
This way we don't get the class files from a dependencies, but we get the proto files and generate the class files ourselves: this way we have more control over how they are generated.
patriknw
approved these changes
Sep 22, 2021
| override def projectSettings: Seq[sbt.Setting[_]] = Seq( | ||
| libraryDependencies ++= Seq( | ||
| "com.akkaserverless" % "akkaserverless-sdk-protocol" % "0.7.0-beta.19" % "protobuf", | ||
| "com.akkaserverless" % "akkaserverless-sdk-protocol" % "0.7.0-beta.19" % "protobuf-src", |
Contributor
There was a problem hiding this comment.
so this will solve the AnnotationsProto issue?
Contributor
Author
There was a problem hiding this comment.
Yes, I'm fairly confident it will (though there might be further problems lurking there, around flat/non-flat packages and naming clashes)
octonato
approved these changes
Sep 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we don't get the class files from a dependencies, but we get
the proto files and generate the class files ourselves: this way we have
more control over how they are generated.