build: move proto test files to common place#456
Conversation
Don't we already have full generation tests, the scripted tests of the sbt plugin? |
My sentence is not clear. Yes, we do have full generation. What I mean, we should be able to have exhaustive generations to be able to catch corner cases. Like usage of outer java class, multi-files, import from other packages, etc. That's why we have this list of files. |
octonato
force-pushed
the
rgc/reuse-protobuf-test-files
branch
from
6a4a294 to
ddbdc63
Compare
patriknw
left a comment
patriknw
left a comment
There was a problem hiding this comment.
LGTM, with a question about how to use them...
| .settings( | ||
| (publish / skip) := true, | ||
| name := "akkaserverless-codegen-java-compilation-tests", | ||
| Compile / PB.protoSources += baseDirectory.value / ".." / ".." / "proto-test-files", |
There was a problem hiding this comment.
Are we going to do something similar like this in the scripted test to include them? Have you tried that it works?
There was a problem hiding this comment.
yes, the goal is to let the scripted test use it.
I didn't try it, but the plan B is to move the files under the scripted tests and let the codegenJavaCompilationTest link to the files there. Although I prefer to have the files in that proto-test-files
3 participants
This is in preparation for full generation tests for the Scala SDK.
We have a bunch of files used by
codegenJavaCompilationTestthat exercise many different options.As we progress with the codegen for Scala, we want the Scala codegen to run on those same files.