fix(codegen-scala): correctly refer to descriptor object#452
fix(codegen-scala): correctly refer to descriptor object#452raboof merged 2 commits intolightbend:mainfrom
Conversation
There is still a problem with the customer-registry sample where Akka gRPC-generated code refers to AnnotationsProto in a way that does not currently work, but that's a separate issue
good that you confirm that, I was trying to understand that in another PR but didn't get anywhere |
patriknw
left a comment
patriknw
left a comment
There was a problem hiding this comment.
LGTM, but I guess the test must be adjusted
| class ValueEntitySourceGeneratorSuite extends munit.FunSuite { | ||
| import com.akkaserverless.codegen.scalasdk.impl.ValueEntitySourceGenerator._ | ||
|
|
||
| // TODO use package naming template parameter to generate Scala-style testData |
| | | ||
| | override final def serviceDescriptor: Descriptors.ServiceDescriptor = | ||
| | ${view.fqn.parent.name}Proto.javaDescriptor.findServiceByName("${view.fqn.protoName}") | ||
| | ${typeName(view.descriptorObject)}.javaDescriptor.findServiceByName("${view.fqn.protoName}") |
There was a problem hiding this comment.
no change in ViewServiceSourceGeneratorSuite?
There was a problem hiding this comment.
no, I suspect thats due to TestData not being entirely realistic still, not sure if it's worth digging into the details
There was a problem hiding this comment.
I see, it's defined as my_service.proto, which accidentally is the same as MyService
| override def fileDescriptorObject(descriptor: Descriptors.FileDescriptor): FullyQualifiedName = | ||
| // TODO move logic from generator classes to here | ||
| ??? |
There was a problem hiding this comment.
this is causing the build to fail
octonato
left a comment
octonato
left a comment
There was a problem hiding this comment.
LGTM, but build is failing because of a ???
I'm looking forward to this as it's also hitting the Actions generations, as well as the AnnotationProto issue
3 participants
There is still a problem with the customer-registry sample
where Akka gRPC-generated code refers to AnnotationsProto
in a way that does not currently work, but that's a separate
issue