chore(docs): some instructions for scripted tests#451
Merged
octonato merged 2 commits intolightbend:mainfrom Sep 22, 2021
Merged
chore(docs): some instructions for scripted tests#451octonato merged 2 commits intolightbend:mainfrom
octonato merged 2 commits intolightbend:mainfrom
Conversation
johanandren
approved these changes
Sep 22, 2021
octonato
reviewed
Sep 22, 2021
| |} | ||
| |object ${entity.fqn.name} { | ||
| | def apply(context: Unit /* ValueEntityContext */):${entity.fqn.name} = | ||
| | new ${entity.fqn.name}("TODO") |
Member
There was a problem hiding this comment.
This commit is unrelated.
I guess you were working on another PR that will bring that change already, correct?
Contributor
There was a problem hiding this comment.
and probably the reason for ci failure
patriknw
approved these changes
Sep 22, 2021
Contributor
patriknw
left a comment
patriknw
left a comment
There was a problem hiding this comment.
LGTM after reverting ValueEntitySourceGenerator.scala
Thanks!
| |} | ||
| |object ${entity.fqn.name} { | ||
| | def apply(context: Unit /* ValueEntityContext */):${entity.fqn.name} = | ||
| | new ${entity.fqn.name}("TODO") |
Contributor
There was a problem hiding this comment.
and probably the reason for ci failure
patriknw
reviewed
Sep 22, 2021
| scripted test has completed (successfully or not) it removes the temporary | ||
| directory where it was running. | ||
|
|
||
| To interactively inspect the project, you can insert a `$ pause` command in the |
Contributor
There was a problem hiding this comment.
I tried
> compile
$ pause
but that will of course not work, since compile fails first.
Can we add clarification that it can be scripted (for debug purposes) like:
> protocGenerate
> generateUnmanaged
$ pause
or whatever you recommend instead
raboof
force-pushed
the
document-sbt-scripted
branch
from
678b18c to
9477aad
Compare
patriknw
reviewed
Sep 22, 2021
| inspect the project, and enter it interactively with | ||
| `cd /tmp/sbt_431151; sbt -Dplugin.version=....`, specifying the snapshot | ||
| version of the project. Adding `> protocGenerate` or `> generateUnmanaged` | ||
| before `$ pause` might save entering sbt yourself a few times. |
Contributor
There was a problem hiding this comment.
ah, ofc the pause should be added at the top (stupid thinking of me)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.