feat(scalasdk): generate action sources for Scala SDK#447
Merged
Conversation
octonato
commented
Sep 21, 2021
Member
Author
octonato
left a comment
octonato
left a comment
There was a problem hiding this comment.
Generated code still not compiling, but I believe this is a general issue in the codegen since the scala-value-entity-customer-registry sample is showing the same issues.
Comment on lines
-76
to
-80
| private def isUnary(cmd: ModelBuilder.Command): Boolean = !cmd.streamedInput && !cmd.streamedOutput | ||
| private def isStreamIn(cmd: ModelBuilder.Command): Boolean = cmd.streamedInput && !cmd.streamedOutput | ||
| private def isStreamOut(cmd: ModelBuilder.Command): Boolean = !cmd.streamedInput && cmd.streamedOutput | ||
| private def isStreamInOut(cmd: ModelBuilder.Command): Boolean = cmd.streamedInput && cmd.streamedOutput | ||
| private def hasStream(cmd: ModelBuilder.Command): Boolean = isStreamIn(cmd) || isStreamOut(cmd) || isStreamInOut(cmd) |
Member
Author
There was a problem hiding this comment.
moved into Command as we need it now in two different generators (Java and Scala)
octonato
force-pushed
the
rgc/actions-codegen-and-samples
branch
from
a73643d to
0fcff33
Compare
patriknw
reviewed
Sep 22, 2021
octonato
force-pushed
the
rgc/actions-codegen-and-samples
branch
from
0fcff33 to
56b9ef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.