Skip to content

fix: invert adapter name, Java2Scala#427

Merged
octonato merged 1 commit intomainfrom
rgc/invert-scala2java
Sep 20, 2021
Merged

fix: invert adapter name, Java2Scala#427
octonato merged 1 commit intomainfrom
rgc/invert-scala2java

Conversation

@octonato
Copy link
Copy Markdown
Member

No description provided.

@octonato octonato requested a review from patriknw September 20, 2021 12:59
Copy link
Copy Markdown
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


private[scalasdk] class Scala2JavaUpdateContextAdapter(val javasdkContext: javasdk.view.UpdateContext)
private[scalasdk] class Java2ScalaUpdateContextAdapter(val javasdkContext: javasdk.view.UpdateContext)
extends UpdateContext {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, that UpdateContext is Scala

@octonato octonato merged commit e24766b into main Sep 20, 2021
@octonato octonato deleted the rgc/invert-scala2java branch September 20, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants