Skip to content

feat(codegen-scala): generate empty main#421

Merged
raboof merged 2 commits intolightbend:mainfrom
raboof:generate-empty-main
Sep 20, 2021
Merged

feat(codegen-scala): generate empty main#421
raboof merged 2 commits intolightbend:mainfrom
raboof:generate-empty-main

Conversation

@raboof
Copy link
Copy Markdown
Contributor

@raboof raboof commented Sep 20, 2021

No description provided.

Copy link
Copy Markdown
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, but would be best to merge #422 first

val unmanagedComment = """|/* This code was generated by Akka Serverless tooling.
| * As long as this file exists it will not be re-generated.
| * You are free to make changes to this file.
| */""".stripMargin
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has moved in #422

}

@tailrec
def longestCommonPrefix(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has moved to SourceGeneratorUtils in #422

|""".stripMargin)
}

def mainPackageName(classNames: Iterable[String]): List[String] = {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has moved to SourceGeneratorUtils in #422

Adding some test scaffolding
@raboof raboof force-pushed the generate-empty-main branch from e7f7448 to 2d10ff8 Compare September 20, 2021 09:07
Copy link
Copy Markdown
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raboof raboof merged commit e291a13 into lightbend:main Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants