Move Service and ComponentOptions to impl.#414
Merged
RayRoestenburg merged 1 commit intomainfrom Sep 20, 2021
Merged
Conversation
RayRoestenburg
force-pushed
the
value_entity_scalasdk
branch
from
73a315f to
fc6ad6f
Compare
patriknw
reviewed
Sep 17, 2021
| package com.akkaserverless.scalasdk | ||
|
|
||
| //FIXME see if needed | ||
| //FIXME see if needed, maybe should be moved to impl |
Contributor
There was a problem hiding this comment.
if it is moved to impl we should (also) include withForwardHeaders and forwardHeaders in the more concrete options interfaces, such as EventSourcedEntityOptions
Contributor
Author
There was a problem hiding this comment.
These interfaces still extend ComponentOptions in impl, so should be good?
RayRoestenburg
force-pushed
the
value_entity_scalasdk
branch
4 times, most recently
from
03ea38e to
4ba0285
Compare
Contributor
Author
|
Ok with this @patriknw ? |
patriknw
reviewed
Sep 20, 2021
| * the headers requested to be forwarded as metadata (cannot be mutated, use withForwardHeaders) | ||
| */ | ||
| Set<String> forwardHeaders(); | ||
| def forwardHeaders(): Set[String] |
Contributor
There was a problem hiding this comment.
I would be more explicit with that Set type. I see that there is an import java.util.Set above but I'd rather have the full package here, or rename the import to JSet.
| import com.akkaserverless.javasdk.impl.eventsourcedentity.EventSourcedEntityOptionsImpl | ||
|
|
||
| import java.util.Collections; | ||
| import java.util.Set; |
| return new EventSourcedEntityOptionsImpl( | ||
| 0, PassivationStrategy.defaultTimeout(), Collections.emptySet()); | ||
| } | ||
| def withForwardHeaders(headers: Set[String]): ComponentOptions |
Contributor
There was a problem hiding this comment.
This is public api and it's somewhat hidden (strange) to only have it via impl. We should add override in all that extends ComponentOptions, for example ActionOptions
RayRoestenburg
force-pushed
the
value_entity_scalasdk
branch
2 times, most recently
from
76a6ea2 to
970ce0a
Compare
johanandren
approved these changes
Sep 20, 2021
Review procesed.
RayRoestenburg
force-pushed
the
value_entity_scalasdk
branch
from
970ce0a to
947b23c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.