fix: align Action / View name convention#405
Conversation
|
reverting to draft, I messed up with something here |
octonato
force-pushed
the
rgc/more-hacks-around-names
branch
from
d53f90a to
5f33bbb
Compare
patriknw
left a comment
patriknw
left a comment
There was a problem hiding this comment.
looking good, is it ready?
octonato
force-pushed
the
rgc/more-hacks-around-names
branch
from
5f33bbb to
8d18593
Compare
|
Ready now, but surprisingly the registration order in in valueentity-customer-registry changed. 🤷 |
octonato
force-pushed
the
rgc/more-hacks-around-names
branch
from
8d18593 to
eb5ebe9
Compare
| CustomerSummaryByNameView::new, | ||
| CustomerByEmailView::new, | ||
| CustomersResponseByNameView::new, | ||
| CustomerByEmailView::new, |
There was a problem hiding this comment.
So, here the names didn't change, but the ordering changed. Note that the CustomerS and Customers (plural).
In any case, the ordering doesn't seen to be deterministic.
CustomerByEmailView
CustomerActionImpl
CustomerByNameView
Alphabetical? Per component type? File system ordering?
|
|
||
| import static org.junit.Assert.*; | ||
|
|
||
| public class CustomerEntityTest { |
There was a problem hiding this comment.
I compiled all project locally and found some files that were not checked in
|
To be strict, the commit comment should be |
octonato
force-pushed
the
rgc/more-hacks-around-names
branch
from
eb5ebe9 to
1cd6ee5
Compare
|
I changed the commit message and fixed the build, we had a failure in the codegen. |
2 participants
Refs: #238
Align the convention and add
Implif name containsAction|View(not only at the end)