feat: sbt plugin 'unmanaged' codegen#401
Merged
raboof merged 2 commits intolightbend:mainfrom Sep 16, 2021
Merged
Conversation
Not entirely happy with the approach: generating the code from the regular protoc generators, but then 'filtering them out' of the managed sources (that they get added to automatically) afterwards, and copying them over 'manually'. It does save us from duplicating part of the sbt-protoc implementation (in particular finding the correct `.proto` files and converting them into `com.google.protobuf.Descriptors.FileDescriptor` instances). Let's try it out, but if it leads to trouble we should definitely consider avoiding the generators and doing that step 'ourselves'.
raboof
force-pushed
the
scala-sbt-unmanaged-codegen
branch
from
fcd64e5 to
7e3b3fa
Compare
pvlugter
approved these changes
Sep 16, 2021
Member
pvlugter
left a comment
pvlugter
left a comment
There was a problem hiding this comment.
The filter on the managed sources does seem a little awkward, but sounds good to start with this approach and see how it goes. And the separate task is good for disabling with Compile / generateUnmanaged := ().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not entirely happy with the approach: generating the code from the regular protoc generators, but then 'filtering them out' of the managed sources (that they get added to automatically) afterwards, and copying them over 'manually'. It does save us from duplicating part of the sbt-protoc implementation (in particular finding the correct
.protofiles and converting them intocom.google.protobuf.Descriptors.FileDescriptorinstances). Let's try it out, but if it leads to trouble we should definitely consider avoiding thegeneratorsand doing that step 'ourselves'.