feat!(scalasdk): WIP#398
Conversation
RayRoestenburg
force-pushed
the
scala-public-api
branch
from
773ffec to
77db0dd
Compare
| @@ -0,0 +1,67 @@ | |||
| akkaserverless { | |||
There was a problem hiding this comment.
This will not work, since we include the reference.conf from javasdk dependency, with the same config properties.
Good news is that it's not needed at all.
There was a problem hiding this comment.
Cool will remove
| } | ||
|
|
||
| object Metadata { | ||
| def empty = new MetadataImpl(JMetadataImpl.Empty) |
|
|
||
| object Metadata { | ||
| def empty = new MetadataImpl(JMetadataImpl.Empty) | ||
| def apply() = empty |
There was a problem hiding this comment.
I think Metadata.empty is enough.
| } | ||
|
|
||
| object Metadata { | ||
| def empty = new MetadataImpl(JMetadataImpl.Empty) |
There was a problem hiding this comment.
always define explicit return types in public api: empty: Metadata
There was a problem hiding this comment.
ah yes, I forget this every time!
RayRoestenburg
force-pushed
the
scala-public-api
branch
5 times, most recently
from
05b6f4f to
1aeb622
Compare
patriknw
left a comment
patriknw
left a comment
There was a problem hiding this comment.
Looking good, let us know when it's in a good shape for first merge. We can add more and fixup incrementally, and that might also make it possible to split the work.
Before starting on all fronts we should probably spike ValueEntity all the way.
RayRoestenburg
force-pushed
the
scala-public-api
branch
3 times, most recently
from
069d3f5 to
a4fdc1e
Compare
patriknw
left a comment
patriknw
left a comment
There was a problem hiding this comment.
LGTM, lets merge this and continue in additional PRs
RayRoestenburg
force-pushed
the
scala-public-api
branch
from
29a92da to
f63bdce
Compare
feat(scalasdk): scaffolding for AkkaServerless, just to compile. Some type scaffolding / glue Not extending from the public facing javasdk. Not ideal yet, but compiles. This might mean later that we have to duplicate some more code. Comment. Structure for ValueEntity. Tmp. AkkaServerlessRunner. Some more wip. More wip. Skip publish of scalasdk.
RayRoestenburg
force-pushed
the
scala-public-api
branch
from
f63bdce to
f45f750
Compare
RayRoestenburg
changed the title
|
Sorry to complain about such unimportant things as the commit message It's not a breaking change, so it shouldn't have The title should be more descriptive, such as Not a big deal at all, but let's improve. |
2 participants
No description provided.