Skip to content

prefix all java samples#394

Merged
octonato merged 1 commit intomainfrom
rgc/prefix-all-samples-with-java
Sep 15, 2021
Merged

prefix all java samples#394
octonato merged 1 commit intomainfrom
rgc/prefix-all-samples-with-java

Conversation

@octonato
Copy link
Copy Markdown
Member

This prefix all existing samples with java- in preparation for the upcoming Scala SDK as we will start to write samples for Scala as well.

I left the valueentity-counter out because it's already done in #373

@octonato
Copy link
Copy Markdown
Member Author

It seems that two of the three replicated entity samples are not used in the docs. There is no link to shopping-cart nor to the counter sample.

Should we remove them to reduce the number of samples to support?

Copy link
Copy Markdown
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread docs/Makefile

bundles:
bin/bundle.sh --zip "${managed_attachments}/customer-registry-quickstart.zip" ../samples/customer-registry-quickstart
bin/bundle.sh --zip "${managed_attachments}/java-customer-registry-quickstart.zip" ../samples/java-customer-registry-quickstart
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will probably require an update to the download link from the quickstart adoc page

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octonato octonato merged commit 5df4317 into main Sep 15, 2021
@octonato octonato deleted the rgc/prefix-all-samples-with-java branch September 15, 2021 11:34
@pvlugter
Copy link
Copy Markdown
Member

It seems that two of the three replicated entity samples are not used in the docs. There is no link to shopping-cart nor to the counter sample.

I added java-replicatedentity-shopping-cart and java-replicatedentity-examples for the docs, and they should both be used there. The counter sample is redundant given the new examples for all the replicated data types, and I think that can be removed.

@octonato
Copy link
Copy Markdown
Member Author

@pvlugter, I may be wrong, but I didn't find any references to replicatedentity-shopping-cart in the docs.

@octonato
Copy link
Copy Markdown
Member Author

Oh, my bad. Checked one again and it's indeed used in replicated-entity-crdt.adoc. I will PR to remove the counter one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants