Populate sbt-plugin 'model', split compile/test#390
Merged
raboof merged 2 commits intolightbend:mainfrom Sep 15, 2021
Merged
Conversation
raboof
force-pushed
the
scala-codegen-infra
branch
from
c46c6ee to
a308250
Compare
octonato
approved these changes
Sep 14, 2021
Comment on lines
+23
to
+25
| if (debugEnabled) println(s"[DEBUG] $message") | ||
| override def info(message: String): Unit = | ||
| if (debugEnabled) println(s"[INFO] $message") |
Contributor
Author
There was a problem hiding this comment.
Yeah... in Akka gRPC we have a hack to pass the sbt logger to the codegen (https://github.com/akka/akka-grpc/blob/e4abdfa60a5b1d3b7b7e816d05e859e16230db5b/sbt-plugin/src/main/scala/akka/grpc/sbt/AkkaGrpcPlugin.scala#L29), but perhaps we can do without here. We can pass fatal problems out, after all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #379