feat: basic sbt plugin#384
Merged
raboof merged 6 commits intolightbend:mainfrom Sep 14, 2021
Merged
Conversation
patriknw
approved these changes
Sep 14, 2021
Contributor
patriknw
left a comment
patriknw
left a comment
There was a problem hiding this comment.
LGTM. Great to reuse the experience from Akka gRPC (I assume).
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.akkaserverless.codegen.scala |
Contributor
There was a problem hiding this comment.
scala or java in the package name is typically not a good idea, can we use scalasdk?
| .settings( | ||
| scalaVersion := Dependencies.ScalaVersionForSbtPlugin, | ||
| buildInfoKeys := Seq[BuildInfoKey](name, organization, version, scalaVersion, sbtVersion), | ||
| buildInfoPackage := "com.akkaserverless.codegen.scala") |
Contributor
There was a problem hiding this comment.
se comment below about package name
octonato
approved these changes
Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With dummy codegen.
This provides nice infrastructure for the part of codegen that happens each time the .proto changes, but not yet for the 'one-off' code generation of code that is supposed to be adapted by the user later. Perhaps that should be an explicit command anyway, to prevent 'leaving behind' generated code and confusing people when class or package names change.
Fixes #379