Conversation
* same config as in akkaserverless-framework
patriknw
force-pushed
the
wip-scalafmt-patriknw
branch
from
04f901b to
7ba5fd0
Compare
raboof
approved these changes
Sep 13, 2021
Contributor
raboof
left a comment
raboof
left a comment
There was a problem hiding this comment.
Now seems to be a good time, perhaps we want to go all the way to 3.0.3?
| @@ -1,24 +1,20 @@ | |||
| version = 2.1.0 | |||
| version = 2.7.5 | |||
Contributor
There was a problem hiding this comment.
Should we go all the way to 3.0.3?
Contributor
Author
patriknw
force-pushed
the
wip-scalafmt-patriknw
branch
from
7931f51 to
0c6df07
Compare
raboof
approved these changes
Sep 13, 2021
| /** | ||
| * INTERNAL API | ||
| * Used by the generated testkit | ||
| * INTERNAL API Used by the generated testkit |
Contributor
There was a problem hiding this comment.
Hmm, perhaps use an extra newline? Not important though.
Contributor
Author
There was a problem hiding this comment.
yeah, that wasn't so helpful formatting, but not important
octonato
approved these changes
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be a decent time to do this now.