chore(docs): update makefile with latest Java SDK version#358
Merged
Conversation
The minimum supported version should come from the SDK itself, not from the main docs repo. Updating this parameter so we can remove the parameter from the main docs repo.
patriknw
approved these changes
Sep 10, 2021
Contributor
patriknw
left a comment
patriknw
left a comment
There was a problem hiding this comment.
LGTM, so many versions all over the place
| echo ":recommended-java-version: 11" \ | ||
| >> "${managed_partials}/attributes.adoc" | ||
| echo ":java_minimum_sdk_version: 0.7.0-beta.19" \ | ||
| echo ":java_minimum_sdk_version: 0.7.0" \ |
Contributor
There was a problem hiding this comment.
is this something we need to push to current/docs to get it out?
Author
There was a problem hiding this comment.
Let's push it during the next release. Johan (or you) created the PR for the main docs already so we got that covered there. Once this is in the current/docs branch, we can make the update in the main docs repo to use this version number rather than what it currently has.
Contributor
There was a problem hiding this comment.
I see. We should improve on the Releasing.md so that all steps are clear.
Author
There was a problem hiding this comment.
Great idea! I'll submit a new PR for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minimum supported version should come from the SDK itself, not from the main docs repo. Updating this parameter so we can remove the parameter from the main docs repo.