cache actionHandlers on creation#34
Merged
octonato merged 1 commit intolightbend:mainfrom Jun 15, 2021
Merged
Conversation
patriknw
approved these changes
Jun 15, 2021
| private object creationContext extends ActionCreationContext { | ||
| override def serviceCallFactory(): ServiceCallFactory = rootContext.serviceCallFactory() | ||
| } | ||
| private val actionHandlers: Map[String, ActionHandler] = services.view.mapValues(_.factory.create(creationContext)).toMap |
Contributor
There was a problem hiding this comment.
I don't think we say anything about the expected concurrency in the action instances, or have a good reason for creating a new instance for each request, so I think this change is fine.
jrudolph
force-pushed
the
avoid-per-call-reflection-lookup
branch
from
4705111 to
616892f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, all the
ActionReflectioncode (looking up methods and annotations, etc) will be re-executed for every single call.