Skip to content

Merging the maven-java project into SDK#28

Merged
octonato merged 216 commits intorgc/feature-branch-maven-javafrom
rgc/maven-plugin-repo-merge
Jun 14, 2021
Merged

Merging the maven-java project into SDK#28
octonato merged 216 commits intorgc/feature-branch-maven-javafrom
rgc/maven-plugin-repo-merge

Conversation

@octonato
Copy link
Copy Markdown
Member

@octonato octonato commented Jun 11, 2021

This brings in the maven-java repo. This is targeting a feature branch called rgc/feature-branch-maven-java.

We may need to simply merge this for now and then continue applying the changes we need to get the CI and other bits the way we want.

Refereces #27

(cc @huntc / @RoryStokes)

huntc and others added 30 commits January 6, 2021 17:52
Added basic archetype based on example, ensured successful compilation
Renamed to akkasls from cloudstate, and some code warning removal/formatting in accordance with VS Code. Also verified that it is able to be packaged.
Also provides a README for the generated project
Ensures that the docker image is correctly named
The beginnings of the generate goal having loaded the classes into memory having compiled them
Introducing the generate goal
@octonato octonato changed the title Rgc/maven plugin repo merge Merging the maven-java project into SDK Jun 11, 2021
@octonato octonato changed the base branch from main to rgc/feature-branch-maven-java June 11, 2021 16:08
@octonato octonato marked this pull request as ready for review June 11, 2021 16:19
Copy link
Copy Markdown
Contributor

@huntc huntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s rip the bandaid off!

franciscolopezsancho pushed a commit to franciscolopezsancho/kalix-jvm-sdk that referenced this pull request Jun 12, 2021
Fix the means of accessing an entity URL
* handle dev-mode
* framework 0.7.0-beta.10
@pvlugter
Copy link
Copy Markdown
Member

Something I did when breaking out the SDKs from framework, was to strip out the #XYZ issue or PR references from commit messages, as these no longer reference the right issues. There are a bunch of references from this PR showing up in other issues currently.

@octonato
Copy link
Copy Markdown
Member Author

Something I did when breaking out the SDKs from framework, was to strip out the #XYZ issue or PR references from commit messages, as these no longer reference the right issues. There are a bunch of references from this PR showing up in other issues currently.

Yeah, I noticed that. Have your wrote a script to do it or did you edit one by one?

@octonato octonato force-pushed the rgc/maven-plugin-repo-merge branch from fc26ce6 to 9b42932 Compare June 14, 2021 08:41
@octonato
Copy link
Copy Markdown
Member Author

I'm merging this since we have one ✅ and that's more ground work.

@octonato
Copy link
Copy Markdown
Member Author

hmm, not merge commit available. Need to change repo's settings.

@octonato octonato merged commit d1acd7b into rgc/feature-branch-maven-java Jun 14, 2021
@octonato octonato deleted the rgc/maven-plugin-repo-merge branch June 14, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants