feat: fallback config for testkit actor system#2377
Merged
Conversation
johanandren
approved these changes
Nov 11, 2025
aludwiko
commented
Nov 11, 2025
| ActorSystem.create( | ||
| "KalixTestkit", | ||
| ConfigFactory.parseString("akka.http.server.preview.enable-http2 = true")); | ||
| ConfigFactory.parseString("akka.http.server.preview.enable-http2 = true") |
Contributor
Author
There was a problem hiding this comment.
TBH I'm not sure about this, because I'm reusing the same fallback config for kalix actor system and for test actor system, maybe this should be sth separate, e.g. KalixTestKit(Main.createKalix(), fallbackTestConfig).start(fallbackConfig) ?
Contributor
There was a problem hiding this comment.
Was also thinking about that but then ended up with "it is probably fine".
Did you try it out to set testkit config like reported by user?
aludwiko
deleted the
4462-kalixtestkit-provide-configuration-to-testsystem
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References: https://github.com/lightbend/akka-runtime/issues/4462?reload=1