Skip to content

Comments

ci: adding javadocs and sources to archetypes#2335

Merged
efgpinto merged 5 commits intomainfrom
add-sources-javadocs
Aug 7, 2025
Merged

ci: adding javadocs and sources to archetypes#2335
efgpinto merged 5 commits intomainfrom
add-sources-javadocs

Conversation

@efgpinto
Copy link
Contributor

@efgpinto efgpinto commented Aug 7, 2025

New plugin central-publishing-maven-plugin requires sources and javadocs to be added when uploading a .jar, see here.

Thus, adding config to produce those on the archetypes. This seems to fix the issue, as it can be seen with this successful publish.

Refs https://github.com/lightbend/kalix/issues/13949

@github-actions github-actions bot added java-sdk-protobuf team-runtime Runtime and SDKs sub-team labels Aug 7, 2025
@efgpinto
Copy link
Contributor Author

efgpinto commented Aug 7, 2025

GH is confused because I run a release from this branch and there the publish of docs failed (as expected), I think. Closing and reopening to see if it solves.

@efgpinto efgpinto closed this Aug 7, 2025
@efgpinto efgpinto reopened this Aug 7, 2025
Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bingo!

@efgpinto
Copy link
Contributor Author

efgpinto commented Aug 7, 2025

ah, I have the power to merge and bypass that rule. I will do so (and then explain myself when I'm called to the boss' office over this :D ).

@efgpinto efgpinto merged commit 088670f into main Aug 7, 2025
115 of 116 checks passed
@efgpinto efgpinto deleted the add-sources-javadocs branch August 7, 2025 17:11
@octonato
Copy link
Member

octonato commented Aug 7, 2025

ah, I have the power to merge and bypass that rule. I will do so (and then explain myself when I'm called to the boss' office over this :D ).

Reporting this to HR for disciplinary measures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java-sdk-protobuf team-runtime Runtime and SDKs sub-team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants