chore: disable virtual threads by default#2333
Merged
johanandren merged 2 commits intomainfrom Aug 6, 2025
Merged
Conversation
github-actions
bot
added
java-sdk-protobuf
team-runtime
ennru
reviewed
Aug 6, 2025
| # Virtual threads usage can be enabled by changing the executor to be "virtual-thread-executor" | ||
| # by default, using the fork join executor for now due to existing issue: https://openjdk.org/jeps/491 | ||
| executor = "fork-join-executor" | ||
| virtual-thread-executor { |
Member
There was a problem hiding this comment.
Should this section be commented out, as well?
Contributor
Author
There was a problem hiding this comment.
Not from a functional perspective... don't see any reason to comment it out. Unless you think it is confusing as is.
Contributor
There was a problem hiding this comment.
I think you should drop it, we have git history with the full old thing anyway
Contributor
Author
There was a problem hiding this comment.
Sure.. You mean dropping the virtual-thread-executor { ... } section, right? or dropping even the config at all and have it hard coded so users cannot change it?
Contributor
There was a problem hiding this comment.
Just the vt config details block that is no longer used for anything
johanandren
approved these changes
Aug 6, 2025
ennru
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not using virtual threads by default until jdk 25 is out, which fixes this issue.
Refs https://github.com/lightbend/kalix/issues/13949