feature: Customer Registry quickstart bootstrap by ennru · Pull Request #203 · lightbend/kalix-jvm-sdk

ennru · 2021-08-10T15:16:42Z

This adds a copy of relevant parts of the java-customer-registry sample as a base for the quickstart sources.

Discovered #202

Refs https://github.com/lightbend/akkaserverless-framework/issues/738

rstento · 2021-08-12T14:48:27Z

@raboof @patriknw, @ennru mentioned that one of you would be moving this PR forward while he is on vacation, do you need anything from me?

raboof · 2021-08-12T14:54:28Z

mentioned that one of you would be moving this PR forward while he is on vacation, do you need anything from me?

I can start having a look tomorrow. I see one of the open tasks is to add an integration test. Is there anything else you'd like to be done here?

rstento · 2021-08-12T15:32:47Z

mentioned that one of you would be moving this PR forward while he is on vacation, do you need anything from me?

I can start having a look tomorrow. I see one of the open tasks is to add an integration test. Is there anything else you'd like to be done here?

Hi @raboof! I'm not sure. I know that one goal was to separate out the event sourced entity because this initial Quickstart is to demonstrate a Value entity and a View. When I finish today, I will create a draft PR with what I have written so far for the Quickstart so that you can get an idea of where its going.

raboof · 2021-08-13T14:25:35Z

I've brought the sample more in line with the codegen and fixed a few issues (#202, #206), now running into #207 while creating the integrationtests (WIP in dd836eb)

Kept README grpcurl examples for this project

Fixes the problem filed as #202

rstento

I know this readme was probably inserted from the codegen template. That template also needs some of these changes.

rstento · 2021-08-17T15:29:55Z

+
+## Designing
+
+While designing your service it is useful to read [designing services](https://developer.lightbend.com/docs/akka-serverless/designing/index.html)


Suggested change

While designing your service it is useful to read [designing services](https://developer.lightbend.com/docs/akka-serverless/designing/index.html)

To understand the Akka Serverless concepts that are a basis for this example, see [Designing services](https://developer.lightbend.com/docs/akka-serverless/designing/index.html) in the documentation.

rstento · 2021-08-17T15:31:10Z

+
+## Developing
+
+This project has a bare-bones skeleton service ready to go, but in order to adapt and


Suggested change

This project has a bare-bones skeleton service ready to go, but in order to adapt and

This project demonstrates use of Value Entity and View components.

rstento · 2021-08-17T15:32:11Z

+## Developing
+
+This project has a bare-bones skeleton service ready to go, but in order to adapt and
+extend it it may be useful to read up on [developing services](https://developer.lightbend.com/docs/akka-serverless/developing/index.html)


Suggested change

extend it it may be useful to read up on [developing services](https://developer.lightbend.com/docs/akka-serverless/developing/index.html)

To understand more about these components, see

rstento · 2021-08-17T15:33:31Z

+
+This project has a bare-bones skeleton service ready to go, but in order to adapt and
+extend it it may be useful to read up on [developing services](https://developer.lightbend.com/docs/akka-serverless/developing/index.html)
+and in particular the [Java section](https://developer.lightbend.com/docs/akka-serverless/java-services/index.html)


rstento · 2021-08-17T15:34:14Z

+
+## Building
+
+To build, at a minimum you need to generate and process sources, particularly when using an IDE.


Not sure this sentence makes sense in the context of this sample, but I'm not sure how to change it?

I agree this is a confusing sentence. Maybe just let's say "You can use Maven to build your project, which will also take care of generating code based on the .proto definitions:"?

(this should probably be updated everywhere)

rstento · 2021-08-17T15:35:12Z

+
+## Running Locally
+
+In order to run your application locally, you must run the Akka Serverless proxy. The included `docker-compose` file contains the configuration required to run the proxy for a locally running application.


Suggested change

In order to run your application locally, you must run the Akka Serverless proxy. The included `docker-compose` file contains the configuration required to run the proxy for a locally running application.

To run the example locally, you must run the Akka Serverless proxy. The included `docker-compose` file contains the configuration required to run the proxy.

rstento · 2021-08-17T15:48:19Z

+[Setting up a local development environment](https://developer.lightbend.com/docs/akka-serverless/getting-started/set-up-development-env.html)
+and configure a Docker Registry to upload your docker image to.
+
+You will need to update the `akkasls.dockerImage` property in the `pom.xml` and refer to


It looks to me like the property is dockerImage not akkasls.dockerImage?

rstento · 2021-08-17T15:48:59Z

+[Configuring registries](https://developer.lightbend.com/docs/akka-serverless/deploying/registries.html)
+for more information on how to make your docker image available to Akka Serverless.
+
+Finally you can or use the [Akka Serverless Console](https://console.akkaserverless.com)


Suggested change

Finally you can or use the [Akka Serverless Console](https://console.akkaserverless.com)

Finally you can use `akkasls` or the [Akka Serverless Console](https://console.akkaserverless.com)

rstento · 2021-08-17T15:50:41Z

+
+Finally you can or use the [Akka Serverless Console](https://console.akkaserverless.com)
+to create a project and then deploy your service into the project either by using `mvn deploy`,
+through the `akkasls` CLI or via the web interface. When using `mvn deploy`, Maven will also


The way this sentence reads, it sounds like they can use mvn deploy in the web interface. It needs to be rewritten because if they use the console, they still need to package and publish the image. Is there a separate mvn target for that that doesn't deploy? If not, we should just tell them to use the CLI.

that is a great question that I don't know the answer to offhand. let's ticketify, #211

patriknw

Looking good. @raboof is this ready for merge? Pls apply Ruth's suggestions.

patriknw · 2021-08-18T06:16:44Z

+            .setEmail("foo@example.com")
+            .build())
+          .toCompletableFuture()
+          .get();


I think we should always have a timeout on such get()

patriknw · 2021-08-18T06:22:11Z

+    loglevel = "DEBUG"
+    logging-filter = "akka.event.slf4j.Slf4jLoggingFilter"
+  }
+}


Created issue #210 for this

raboof · 2021-08-18T10:00:16Z

I think I covered all the feedback and this is ready to merge now

patriknw

LGTM

ennru added the team-runtime Runtime and SDKs sub-team label Aug 10, 2021

raboof self-assigned this Aug 13, 2021

raboof mentioned this pull request Aug 13, 2021

View codegen must create component registration #202

Closed

ennru and others added 9 commits August 17, 2021 11:03

feature: Customer Registry quickstart bootstrap

fcff4f1

Update README and docker files as generated

b680f1c

Kept README grpcurl examples for this project

Automatically register the view

47393d6

Fixes the problem filed as #202

WIP adding an integrationtest to the quickstart sample

9f1d36b

wip

01aacf4

Test creating user, setting name/address

b2ef1f5

Remove helpers

164d1e2

Add integration test for view

89c0abe

Enable integration tests for quickstart

f8c00dd

raboof marked this pull request as ready for review August 17, 2021 10:52

rstento requested a review from patriknw August 17, 2021 15:11

rstento suggested changes Aug 17, 2021

View reviewed changes

patriknw reviewed Aug 18, 2021

View reviewed changes

raboof mentioned this pull request Aug 18, 2021

Instructions for deploying a service #211

Closed

raboof added 2 commits August 18, 2021 11:22

Updates to README instructions

244893a

Specify a timeout for .get()

88385e9

patriknw approved these changes Aug 18, 2021

View reviewed changes

patriknw merged commit 916fd89 into lightbend:main Aug 18, 2021

ennru deleted the ennru-init-quickstart branch August 19, 2021 10:01

rstento mentioned this pull request Aug 20, 2021

Document JavaScript Quickstart for Value Entities lightbend/kalix-javascript-sdk#161

Closed


		## Designing

		While designing your service it is useful to read [designing services](https://developer.lightbend.com/docs/akka-serverless/designing/index.html)

	While designing your service it is useful to read [designing services](https://developer.lightbend.com/docs/akka-serverless/designing/index.html)
	To understand the Akka Serverless concepts that are a basis for this example, see [Designing services](https://developer.lightbend.com/docs/akka-serverless/designing/index.html) in the documentation.


		## Developing

		This project has a bare-bones skeleton service ready to go, but in order to adapt and

	This project has a bare-bones skeleton service ready to go, but in order to adapt and
	This project demonstrates use of Value Entity and View components.

	extend it it may be useful to read up on [developing services](https://developer.lightbend.com/docs/akka-serverless/developing/index.html)
	To understand more about these components, see


		## Building

		To build, at a minimum you need to generate and process sources, particularly when using an IDE.


		## Running Locally

		In order to run your application locally, you must run the Akka Serverless proxy. The included `docker-compose` file contains the configuration required to run the proxy for a locally running application.

	In order to run your application locally, you must run the Akka Serverless proxy. The included `docker-compose` file contains the configuration required to run the proxy for a locally running application.
	To run the example locally, you must run the Akka Serverless proxy. The included `docker-compose` file contains the configuration required to run the proxy.

	Finally you can or use the [Akka Serverless Console](https://console.akkaserverless.com)
	Finally you can use `akkasls` or the [Akka Serverless Console](https://console.akkaserverless.com)

Conversation

ennru commented Aug 10, 2021

Uh oh!

rstento commented Aug 12, 2021

Uh oh!

raboof commented Aug 12, 2021

Uh oh!

rstento commented Aug 12, 2021

Uh oh!

raboof commented Aug 13, 2021

Uh oh!

rstento left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raboof Aug 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raboof Aug 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

patriknw left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raboof commented Aug 18, 2021

Uh oh!

patriknw left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

raboof Aug 18, 2021 •

edited

Loading

raboof Aug 18, 2021 •

edited

Loading