Skip to content

Don't skip deploying the maven-java pom#174

Merged
raboof merged 1 commit intolightbend:mainfrom
raboof:deploy-parent-pom
Jul 28, 2021
Merged

Don't skip deploying the maven-java pom#174
raboof merged 1 commit intolightbend:mainfrom
raboof:deploy-parent-pom

Conversation

@raboof
Copy link
Copy Markdown
Contributor

@raboof raboof commented Jul 28, 2021

It is required since the other projects have this pom as their parent
pom. Refs #173

It is required since the other projects have this pom as their parent
pom. Refs lightbend#173
@hseeberger
Copy link
Copy Markdown

@raboof, I only see changes to maven-java/pom.xml. There you removed stuff. How does this lead to the desired effect of not skipping deployment of the mavan-java POM?

@raboof
Copy link
Copy Markdown
Contributor Author

raboof commented Jul 28, 2021

@raboof, I only see changes to maven-java/pom.xml. There you removed stuff. How does this lead to the desired effect of not skipping deployment of the mavan-java POM?

Specifically the removal of

        <configuration>
          <skip>true</skip>
        </configuration>

from the deploy plugin configuration of the parent pom

Copy link
Copy Markdown

@hseeberger hseeberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raboof raboof merged commit 312eb3f into lightbend:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants