feat: add some logging to codegen#165
Merged
octonato merged 2 commits intolightbend:sdk-codegen-devfrom Jul 22, 2021
Merged
Conversation
Notably for the case where there is an entity service, but no entity component configuration that matches by the component name - in which case nothing would be generated, silently.
pvlugter
approved these changes
Jul 22, 2021
Member
pvlugter
left a comment
pvlugter
left a comment
There was a problem hiding this comment.
👍🏼 good to have this warning. Should this be added to main branch too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notably for the case where there is an entity service,
but no entity component configuration that matches by
the component name - in which case nothing would be
generated, silently.