Skip to content

fix: update sample sdk version with sed #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raboof merged 1 commit into from
Jul 20, 2021
Merged

fix: update sample sdk version with sed #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,29 +200,25 @@ jobs:
command: |
cd samples/java-valueentity-shopping-cart
echo "Running mvn with SDK version: '$SDK_VERSION'"
mvn versions:set -DnewVersion=$SDK_VERSION
mvn verify -Pit
mvn -Dakkaserverless-sdk.version=$SDK_VERSION verify -Pit
- run:
name: Run integration tests for Shopping Cart Event Sourced Entity sample
command: |
cd samples/java-eventsourced-shopping-cart
echo "Running mvn with SDK version: '$SDK_VERSION'"
mvn versions:set -DnewVersion=$SDK_VERSION
mvn verify -Pit
mvn -Dakkaserverless-sdk.version=$SDK_VERSION verify -Pit
- run:
name: Run integration tests for Counter Value Entity sample
command: |
cd samples/valueentity-counter
echo "Running mvn with SDK version: '$SDK_VERSION'"
mvn versions:set -DnewVersion=$SDK_VERSION
mvn verify -Pit
mvn -Dakkaserverless-sdk.version=$SDK_VERSION verify -Pit
- run:
name: Run integration tests for Counter Replicated Entity sample
command: |
cd samples/replicatedentity-counter
echo "Running mvn with SDK version: '$SDK_VERSION'"
mvn versions:set -DnewVersion=$SDK_VERSION
mvn verify -Pit
mvn -Dakkaserverless-sdk.version=$SDK_VERSION verify -Pit
- save_deps_cache

publish:
Expand Down
4 changes: 2 additions & 2 deletions maven-java/akkaserverless-maven-archetype-event-sourced-entity/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
<modelVersion>4.0.0</modelVersion>

<artifactId>akkaserverless-maven-archetype-event-sourced-entity</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.7.0-beta.15</version>
<packaging>maven-archetype</packaging>
<parent>
<groupId>com.akkaserverless</groupId>
<artifactId>akkaserverless-maven-java</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.7.0-beta.15</version>
</parent>

<name>Akka Serverless Maven Archetype (Event Sourced entity)</name>
Expand Down
4 changes: 2 additions & 2 deletions maven-java/akkaserverless-maven-archetype-value-entity/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
<modelVersion>4.0.0</modelVersion>

<artifactId>akkaserverless-maven-archetype</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.7.0-beta.15</version>
<packaging>maven-archetype</packaging>
<parent>
<groupId>com.akkaserverless</groupId>
<artifactId>akkaserverless-maven-java</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.7.0-beta.15</version>
</parent>

<name>Akka Serverless Maven Archetype (Value entity)</name>
Expand Down
4 changes: 2 additions & 2 deletions maven-java/akkaserverless-maven-plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@

<groupId>com.akkaserverless</groupId>
<artifactId>akkaserverless-maven-plugin</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.7.0-beta.15</version>
<packaging>maven-plugin</packaging>
<parent>
<groupId>com.akkaserverless</groupId>
<artifactId>akkaserverless-maven-java</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.7.0-beta.15</version>
</parent>

<name>Akka Serverless Maven Plugin</name>
Expand Down
2 changes: 1 addition & 1 deletion maven-java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<groupId>com.akkaserverless</groupId>
<artifactId>akkaserverless-maven-java</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.7.0-beta.15</version>
<packaging>pom</packaging>

<url>https://www.lightbend.com/akkaserverless</url>
Expand Down
12 changes: 1 addition & 11 deletions samples/java-customer-registry/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<akkasls.dockerTag>${project.version}</akkasls.dockerTag>
<akkasls.mainClass>customer.Main</akkasls.mainClass>
<jdk.target>11</jdk.target>
<akkaserverless-sdk.version>${project.version}</akkaserverless-sdk.version>
<akkaserverless-sdk.version>0.7.0-beta.15</akkaserverless-sdk.version>
<akka-grpc.version>1.1.1</akka-grpc.version>
</properties>

Expand Down Expand Up @@ -51,16 +51,6 @@
</configuration>
</plugin>

<plugin>
<!--
this plugin allow us to change the version of this projects and submodules
we use it in CI to align the project with the current SDK version
-->
<groupId>org.codehaus.mojo</groupId>
<artifactId>versions-maven-plugin</artifactId>
<version>2.8.1</version>
</plugin>

<plugin>
<groupId>org.xolstice.maven.plugins</groupId>
<artifactId>protobuf-maven-plugin</artifactId>
Expand Down
12 changes: 1 addition & 11 deletions samples/java-eventing-shopping-cart/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<akkasls.dockerTag>${project.version}</akkasls.dockerTag>
<akkasls.mainClass>shopping.Main</akkasls.mainClass>
<jdk.target>11</jdk.target>
<akkaserverless-sdk.version>${project.version}</akkaserverless-sdk.version>
<akkaserverless-sdk.version>0.7.0-beta.15</akkaserverless-sdk.version>
<akka-grpc.version>1.1.1</akka-grpc.version>
</properties>

Expand Down Expand Up @@ -51,16 +51,6 @@
<target>${jdk.target}</target>
</configuration>
</plugin>

<plugin>
<!--
this plugin allow us to change the version of this projects and submodules
we use it in CI to align the project with the current SDK version
-->
<groupId>org.codehaus.mojo</groupId>
<artifactId>versions-maven-plugin</artifactId>
<version>2.8.1</version>
</plugin>

<plugin>
<groupId>org.xolstice.maven.plugins</groupId>
Expand Down
12 changes: 1 addition & 11 deletions samples/java-eventsourced-shopping-cart/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<jdk.target>11</jdk.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<akkaserverless-sdk.version>${project.version}</akkaserverless-sdk.version>
<akkaserverless-sdk.version>0.7.0-beta.15</akkaserverless-sdk.version>
<akka-grpc.version>1.1.1</akka-grpc.version>
</properties>

Expand Down Expand Up @@ -52,16 +52,6 @@
<target>${jdk.target}</target>
</configuration>
</plugin>

<plugin>
<!--
this plugin allow us to change the version of this projects and submodules
we use it in CI to align the project with the current SDK version
-->
<groupId>org.codehaus.mojo</groupId>
<artifactId>versions-maven-plugin</artifactId>
<version>2.8.1</version>
</plugin>

<plugin>
<groupId>org.xolstice.maven.plugins</groupId>
Expand Down
12 changes: 1 addition & 11 deletions samples/java-valueentity-shopping-cart/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<jdk.target>11</jdk.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<akkaserverless-sdk.version>${project.version}</akkaserverless-sdk.version>
<akkaserverless-sdk.version>0.7.0-beta.15</akkaserverless-sdk.version>
<akka-grpc.version>1.1.1</akka-grpc.version>
</properties>

Expand Down Expand Up @@ -52,16 +52,6 @@
<target>${jdk.target}</target>
</configuration>
</plugin>

<plugin>
<!--
this plugin allow us to change the version of this projects and submodules
we use it in CI to align the project with the current SDK version
-->
<groupId>org.codehaus.mojo</groupId>
<artifactId>versions-maven-plugin</artifactId>
<version>2.8.1</version>
</plugin>

<plugin>
<groupId>org.xolstice.maven.plugins</groupId>
Expand Down
12 changes: 1 addition & 11 deletions samples/replicatedentity-counter/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<jdk.target>11</jdk.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<akkaserverless-sdk.version>${project.version}</akkaserverless-sdk.version>
<akkaserverless-sdk.version>0.7.0-beta.15</akkaserverless-sdk.version>
<akka-grpc.version>1.1.1</akka-grpc.version>
</properties>

Expand Down Expand Up @@ -52,16 +52,6 @@
<target>${jdk.target}</target>
</configuration>
</plugin>

<plugin>
<!--
this plugin allow us to change the version of this projects and submodules
we use it in CI to align the project with the current SDK version
-->
<groupId>org.codehaus.mojo</groupId>
<artifactId>versions-maven-plugin</artifactId>
<version>2.8.1</version>
</plugin>

<plugin>
<groupId>org.xolstice.maven.plugins</groupId>
Expand Down
2 changes: 1 addition & 1 deletion samples/valueentity-counter/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<jdk.target>11</jdk.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<akkaserverless-sdk.version>${project.version}</akkaserverless-sdk.version>
<akkaserverless-sdk.version>0.7.0-beta.15</akkaserverless-sdk.version>
<akka-grpc.version>1.1.1</akka-grpc.version>
</properties>

Expand Down
9 changes: 3 additions & 6 deletions updatePomVersions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ fi

for i in samples/*
do
(
cd $i
mvn versions:set -DnewVersion=$SDK_VERSION
rm pom.xml.versionsBackup
)
done
sed -i .versionsBackup "s/<akkaserverless-sdk.version>\(.*\)<\/akkaserverless-sdk.version>/<akkaserverless-sdk.version>$SDK_VERSION<\/akkaserverless-sdk.version>/" $i/pom.xml
rm $i/pom.xml.versionsBackup
Comment on lines +30 to +31
Copy link
Copy Markdown
Member Author

@octonato octonato Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to sed docs, one could omit the extension when using -i, but it didn't work for me.

Also, the recommended usage is to create a backup file. We don't really need it, so I delete it as soon as we know that the file was written.

done