Skip to content

fix: preserve execution dir#158

Merged
octonato merged 2 commits intomainfrom
rgc/fix-update-pom-script
Jul 19, 2021
Merged

fix: preserve execution dir#158
octonato merged 2 commits intomainfrom
rgc/fix-update-pom-script

Conversation

@octonato
Copy link
Copy Markdown
Member

@octonato octonato commented Jul 19, 2021

There is a small mistake on the updatePomVersions.sh script. We should not permanently move in maven-java directory.

@octonato octonato marked this pull request as draft July 19, 2021 09:30
@octonato
Copy link
Copy Markdown
Member Author

octonato commented Jul 19, 2021

marking as draft because there is another error in this script

@octonato octonato marked this pull request as ready for review July 19, 2021 09:35
@octonato
Copy link
Copy Markdown
Member Author

octonato commented Jul 19, 2021

marking as draft because there is another error in this script

fixed in 3427c40

@octonato
Copy link
Copy Markdown
Member Author

octonato commented Jul 19, 2021

@raboof, once we get this merge, I will integrate it in #157. So please wait with #157 otherwise we will need another main -> sdk branch merge.

@octonato octonato merged commit 80c0208 into main Jul 19, 2021
@octonato octonato deleted the rgc/fix-update-pom-script branch July 19, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@raboof raboof raboof approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@octonato @raboof