Skip to content

changing to Abstract#101

Closed
franciscolopezsancho wants to merge 1 commit intolightbend:mainfrom
franciscolopezsancho:renaming-interface-dependency
Closed

changing to Abstract#101
franciscolopezsancho wants to merge 1 commit intolightbend:mainfrom
franciscolopezsancho:renaming-interface-dependency

Conversation

@franciscolopezsancho
Copy link
Copy Markdown
Contributor

@franciscolopezsancho franciscolopezsancho commented Jul 5, 2021

this is a consecuence of changing the codegen naming from Interface to Abstract

Depends on
#99 to work

franciscolopezsancho added a commit to franciscolopezsancho/kalix-jvm-sdk that referenced this pull request Jul 5, 2021
Copy link
Copy Markdown
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pvlugter
Copy link
Copy Markdown
Member

pvlugter commented Jul 6, 2021

This is failing the tests. Does it just need a rebase with the other rename changes? Or do the tests not actually use the local dev version or something?

The Interface file is still generated:

[INFO] Running com.akkaserverless.GenerateMojoTest
[info] Inspecting proto file descriptor for entity generation...
[info] Generated: src/main/java/com/example/shoppingcart/domain/ShoppingCartImpl.java
[info] Generated: target/generated-sources/akkaserverless/java/com/example/shoppingcart/domain/ShoppingCartInterface.java
[info] Generated: src/test/java/com/example/shoppingcart/domain/ShoppingCartTest.java
[info] Generated: src/it/java/com/example/shoppingcart/domain/ShoppingCartIntegrationTest.java
[info] Generated: target/generated-sources/akkaserverless/java/com/lightbend/MainComponentRegistrations.java
[info] Generated: src/main/java/com/lightbend/Main.java
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.931 s <<< FAILURE! - in com.akkaserverless.GenerateMojoTest
[ERROR] testGeneration(com.akkaserverless.GenerateMojoTest)  Time elapsed: 2.763 s  <<< FAILURE!
java.lang.AssertionError
	at com.akkaserverless.GenerateMojoTest.testGeneration(GenerateMojoTest.java:39)

@franciscolopezsancho
Copy link
Copy Markdown
Contributor Author

hey @pvlugter I understand this is failing because it's using the old codegen to generate [info] Generated: target/generated-sources/akkaserverless/java/com/example/shoppingcart/domain/ShoppingCartInterface.java . The new codegen produces AbstractShoppingCart.

I think the problem is this CI doesn't generate the codegen in every run and uses it. Rather, as you mention, uses some local and/or some hard coded version.

@raboof
Copy link
Copy Markdown
Contributor

raboof commented Jul 6, 2021

I think the problem is this CI doesn't generate the codegen in every run and uses it.

This is being worked on in #105

@johanandren
Copy link
Copy Markdown
Contributor

GenerateMojoTest.java now fixed in #105 and merged to main

@johanandren johanandren closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants