You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is failing the tests. Does it just need a rebase with the other rename changes? Or do the tests not actually use the local dev version or something?
The Interface file is still generated:
[INFO] Running com.akkaserverless.GenerateMojoTest
[info] Inspecting proto file descriptor for entity generation...
[info] Generated: src/main/java/com/example/shoppingcart/domain/ShoppingCartImpl.java
[info] Generated: target/generated-sources/akkaserverless/java/com/example/shoppingcart/domain/ShoppingCartInterface.java
[info] Generated: src/test/java/com/example/shoppingcart/domain/ShoppingCartTest.java
[info] Generated: src/it/java/com/example/shoppingcart/domain/ShoppingCartIntegrationTest.java
[info] Generated: target/generated-sources/akkaserverless/java/com/lightbend/MainComponentRegistrations.java
[info] Generated: src/main/java/com/lightbend/Main.java
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.931 s <<< FAILURE! - in com.akkaserverless.GenerateMojoTest
[ERROR] testGeneration(com.akkaserverless.GenerateMojoTest) Time elapsed: 2.763 s <<< FAILURE!
java.lang.AssertionError
at com.akkaserverless.GenerateMojoTest.testGeneration(GenerateMojoTest.java:39)
hey @pvlugter I understand this is failing because it's using the old codegen to generate [info] Generated: target/generated-sources/akkaserverless/java/com/example/shoppingcart/domain/ShoppingCartInterface.java . The new codegen produces AbstractShoppingCart.
I think the problem is this CI doesn't generate the codegen in every run and uses it. Rather, as you mention, uses some local and/or some hard coded version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a consecuence of changing the codegen naming from Interface to Abstract
Depends on
#99 to work