Pass undef if semantic function argument is unused#716
Merged
Ninja3047 merged 1 commit intolifting-bits:masterfrom Jul 4, 2025
Merged
Pass undef if semantic function argument is unused#716Ninja3047 merged 1 commit intolifting-bits:masterfrom
Ninja3047 merged 1 commit intolifting-bits:masterfrom
Conversation
Remill tries to infer the proper type of an argument for a semantic function. If the argument is unused that won't work and yields wrong results. However, in that case, it doesn't matter what's passed, as nobody uses the value, so passing undef works and prevents issues.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
IntendedArgumentTypeto resolve the intended argument type fails if the argument has no uses.This is for example the case for the destination register of the
FLDinstruction semantics:remill/lib/Arch/X86/Semantics/X87.cpp
Line 119 in d13d43f
Not being able to resolve the intended type will then lead to the destination register being treated as source.
This in turn causes an assertion to be thrown.
As the argument is unused though, it doesn't matter what's passed. Therefore passing
undefwill work just fine.