Sleigh Preliminary Floating Point Support#632
Merged
Conversation
sschriner
previously requested changes
Oct 6, 2022
pgoodman
reviewed
Oct 10, 2022
lkorenc
approved these changes
Oct 11, 2022
pgoodman
reviewed
Oct 26, 2022
pgoodman
approved these changes
Oct 26, 2022
Contributor
pgoodman
left a comment
pgoodman
left a comment
There was a problem hiding this comment.
TODOs:
- File issue for adding the isnan intrinsic support when it becomes available.
- Decide if you want to add HalfTy and other LLVM float types to the p-code lifter now or later.
Otherwise, this looks good to merge.
pgoodman
approved these changes
Oct 28, 2022
pgoodman
dismissed
sschriner’s stale review
It is marked as resolved but github hasn't figured it out, and that is blocking merge.
2over12
force-pushed
the
ian/floating_point_sleigh
branch
from
2d60b1e to
8b95ce2
Compare
pgoodman
approved these changes
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.