Conversation
| ) | ||
|
|
||
| # Windows SDK | ||
| add_library(thirdparty_win32 INTERFACE) |
There was a problem hiding this comment.
this doesn't appear to be used so i just deleted it?
| ) | ||
|
|
||
| set(THIRDPARTY_LIBRARY_LIST thirdparty_llvm thirdparty_xed thirdparty_glog thirdparty_gflags thirdparty_sleigh) | ||
| target_link_libraries(remill_settings INTERFACE |
There was a problem hiding this comment.
should deps go into _settings as well?
There was a problem hiding this comment.
It depends on how precise you want to be with the linking of the dependencies to the various libraries/executables.
Ideally, you only link to the dependencies you need, but adding them here means you only need to change one spot 🤷
| # Exported Targets | ||
| include("${CMAKE_CURRENT_LIST_DIR}/remillTargets.cmake") | ||
|
|
||
| if(TARGET thirdparty_llvm) |
There was a problem hiding this comment.
unsure what this was doing so i just deleted it and it didn't appear to break anything
| ) | ||
|
|
||
| set(THIRDPARTY_LIBRARY_LIST thirdparty_llvm thirdparty_xed thirdparty_glog thirdparty_gflags thirdparty_sleigh) | ||
| target_link_libraries(remill_settings INTERFACE |
There was a problem hiding this comment.
It depends on how precise you want to be with the linking of the dependencies to the various libraries/executables.
Ideally, you only link to the dependencies you need, but adding them here means you only need to change one spot 🤷
2 participants
it compiles but may have unintentially broke things