Fix Type Info for Register Variable GEPs#620
Merged
Conversation
2over12
changed the title
pgoodman
approved these changes
Aug 20, 2022
Contributor
Author
|
Hmm looks like this approach introduces a bug... not sure will have to look into it EDIT: Ok the problem here is metavariables, ive pushed up a PR that uses the gep type for metavariables, but there may be cases where this falls over? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #618 by returning the type from the arches reg info rather than the inferred type of the GEP.