Skip to content

Filter for only loads that modify pc #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2over12 merged 1 commit into from
Mar 25, 2022
Merged

Filter for only loads that modify pc #584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/Arch/AArch32/Decode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1751,7 +1751,7 @@ static bool TryDecodeLoadStoreWordUBIL(Instruction &inst, uint32_t bits) {
// The semantics for these instructions take `next_pc` as
// arguments and should update it accordingly.

if (enc.rt == kPCRegNum) {
if (enc.rt == kPCRegNum && kRegAction == Operand::Action::kActionWrite) {
AddAddrRegOp(inst, kNextPCVariableName.data(), kAddressSize,
Operand::kActionWrite, 0);

Expand Down Expand Up @@ -1859,7 +1859,7 @@ static bool TryDecodeLoadStoreWordUBReg(Instruction &inst, uint32_t bits) {
// The semantics for these instructions take `next_pc` as
// arguments and should update it accordingly.

if (enc.rt == kPCRegNum) {
if (enc.rt == kPCRegNum && kRegAction == Operand::Action::kActionWrite) {
AddAddrRegOp(inst, kNextPCVariableName.data(), kAddressSize,
Operand::kActionWrite, 0);

Expand Down Expand Up @@ -2032,7 +2032,7 @@ static bool TryDecodeLoadStoreDualHalfSignedBIL(Instruction &inst,
// The semantics for these instructions take `next_pc` as
// arguments and should update it accordingly.

if (enc.rt == kPCRegNum) {
if (enc.rt == kPCRegNum && kRegAction == Operand::Action::kActionWrite) {
AddAddrRegOp(inst, kNextPCVariableName.data(), kAddressSize,
Operand::kActionWrite, 0);

Expand Down Expand Up @@ -2341,7 +2341,8 @@ static bool TryDecodeLoadStoreMultiple(Instruction &inst, uint32_t bits) {
// take care of identifying if its indirect jump
//

if (enc.register_list & (0b1 << 15u)) {
if ((enc.register_list & (0b1 << 15u)) &&
kRegAction == Operand::Action::kActionWrite) {
AddAddrRegOp(inst, kNextPCVariableName.data(), kAddressSize,
Operand::kActionWrite, 0);

Expand Down