add some semantic function of instructions#562
Merged
pgoodman merged 3 commits intolifting-bits:masterfrom Nov 24, 2021
Merged
Conversation
pgoodman
suggested changes
Nov 23, 2021
Contributor
pgoodman
left a comment
There was a problem hiding this comment.
Mostly superficial changes requested. We'd be very interested in those other 296 semantics!
Contributor
|
It looks like this relies on the K registers to be in place, so I'll wait on that PR to be merged. Otherwise, excellent work! |
pgoodman
approved these changes
Nov 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I added semantic functions, I found that there are many instructions in remill that did not add corresponding semantic functions, such as VPMOVSXBQ and VPMOVSXWD. I added more than 300 similar instructions when doing related work, such as
If you are satisfied, I can upload all the instructions I have added to the community to help remill expand and support conversion of more instructions.