[MERGED] udev: Update Nintendo Co., Ltd. Pro Controller (default-off).cfg and create Nintendo Switch Pro Controller (default-off).cfg / Pro Controller (default-off).cfg copies#1161
Closed
davidhedlund wants to merge 30 commits intolibretro:masterfrom
davidhedlund:patch-43
Closed
[MERGED] udev: Update Nintendo Co., Ltd. Pro Controller (default-off).cfg and create Nintendo Switch Pro Controller (default-off).cfg / Pro Controller (default-off).cfg copies#1161davidhedlund wants to merge 30 commits intolibretro:masterfrom davidhedlund:patch-43
Nintendo Co., Ltd. Pro Controller (default-off).cfg and create Nintendo Switch Pro Controller (default-off).cfg / Pro Controller (default-off).cfg copies#1161davidhedlund wants to merge 30 commits intolibretro:masterfrom
davidhedlund:patch-43
Conversation
Added line breaks to solve variable truncation issue
davidhedlund
changed the title
The udev driver depends on input_device, rather than input_vendor_id and input_product_id.
# Remove input_vendor_id and input_product_id once this issue has been solved: [IMPORTANT] Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904 input_vendor_id = "1406" input_product_id = "8201"
# The files "Nintendo Co., Ltd. Pro Controller.cfg" and "Nintendo Switch Pro Controller.cfg" should have identical content except for the input_device variable. This difference allows the linuxraw and udev drivers to recognize the controller on various Linux kernel versions.
# The files "Nintendo Co., Ltd. Pro Controller.cfg" and "Nintendo Switch Pro Controller.cfg" should have identical content except for the input_device variable. This difference allows the linuxraw and udev drivers to recognize the controller on various Linux kernel versions.
davidhedlund
changed the title
Nintendo Switch Pro Controller.cfg copy
It seems more straightforward for a single pull request to remove input_vendor_id from all udev files once we reach a consensus on the issue discussed in: libretro/RetroArch#16907
It seems more straightforward for a single pull request to remove input_vendor_id from all udev files once we reach a consensus on the issue discussed in: libretro/RetroArch#16907
Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904
Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904
Removed the final comments
Removed the final comments
input_device_display_name = "Nintendo Switch Pro Controller (USB)"
input_device_display_name = "Nintendo Switch Pro Controller (USB)"
same name for both USB and Bluetooth
…o., Ltd. Pro Controller (default-off2).cfg
…ch Pro Controller (default-off2).cfg
davidhedlund
changed the title
Nintendo Switch Pro Controller.cfg copyNintendo Switch Pro Controller.cfg / Pro Controller.cfg copies
davidhedlund
changed the title
Nintendo Switch Pro Controller.cfg / Pro Controller.cfg copiesNintendo Co., Ltd. Pro Controller.cfg and create Nintendo Switch Pro Controller.cfg / Pro Controller.cfg copies
davidhedlund
changed the title
Nintendo Co., Ltd. Pro Controller.cfg and create Nintendo Switch Pro Controller.cfg / Pro Controller.cfg copiesNintendo Co., Ltd. Pro Controller (default-off).cfg and create Nintendo Switch Pro Controller (default-off).cfg / Pro Controller (default-off).cfg copies
…do Co., Ltd. Pro Controller (default-off).cfg
…Switch Pro Controller (default-off).cfg
davidhedlund
changed the title
Nintendo Co., Ltd. Pro Controller (default-off).cfg and create Nintendo Switch Pro Controller (default-off).cfg / Pro Controller (default-off).cfg copiesNintendo Co., Ltd. Pro Controller (default-off).cfg and create Nintendo Switch Pro Controller (default-off).cfg / Pro Controller (default-off).cfg copies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve significant confusion:
Nintendo Co., Ltd. Pro Controller (old).cfgtoPro Controller (non-HID) (default-off).cfg#1185