You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Has this change been profiled? It looks like it would affect performance. Though maybe a good reason to look into improving the performance of the RDB parsing code, it is unnecessarily slow last time I looked at it.
Not explicitly profiled, no extra delay was obvious during testing.
Memory usage should not be higher than what is actually needed to store all the found metadata (which was intended to be there anyway). Initial explore menu setup may take slightly longer as the database is read in full instead of stopping after the same amount of hits as titles, but this is probably only significant if there are many systems (=many rdb files read), but only a few titles per system.
RDB optimization may be anyway welcome - when the database extension (see on Discord) lands, rdb's may be significantly larger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove an early return condition from explore menu item collection. In case of NES database, this caused Explore menu to be quite limited.
Related Issues
Closes #11275 . Or, at least, helps the situation, depending on the CRC match.