(cheevos) update to rcheevos 12.3#18719
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Feb 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's a couple minor bugfixes being pulled in, but the primary driver for this change is a new function that returns the next most likely achievement to be unlocked. This can be used to mitigate some of the feedback from #18639. Instead of loading all badges on demand (new behavior) or all badges up front (old behavior), this allows the next most likely to unlock badge to be downloaded. Then, any time an achievement is unlocked, the next most likely to unlock badge is downloaded. This keeps the cache small, and the eliminates the initial stutter, which minimizing the amount of time when the placeholder badge is shown.
The full list can still be predownloaded by opening the achievements menu.
There was also a suggestion to delay the popup until the badge is available, which I'm still considering, but that's a bit more complicated and I think it deserves a separate PR.
Related Issues
#18639 (comment)
Related Pull Requests
n/a
Reviewers
[If possible @mention all the people that should review your pull request]