Conversation
menu/menu_defines.h
Outdated
| RGUI_THEME_LAGOON, | ||
| RGUI_THEME_BROGRAMMER, | ||
| RGUI_THEME_DRACULA, | ||
| RGUI_THEME_EVERGARDEN, |
There was a problem hiding this comment.
Inserting new ones in between these will break existing configs that use themes after it.
menu/menu_defines.h
Outdated
| OZONE_COLOR_THEME_HACKING_THE_KERNEL, | ||
| OZONE_COLOR_THEME_TWILIGHT_ZONE, | ||
| OZONE_COLOR_THEME_DRACULA, | ||
| OZONE_COLOR_THEME_EVERGARDEN, |
|
Please don't mimic any alphabetical stuff with these things this way, as mentioned in the review. Pretty much too late to do anything else for readability other than create new config values as strings for all of these that save only the enum integer.. |
|
sorry, thnx for the note. I guess alphabetical ordering wasn't the best choice there. |
comfysage
force-pushed
the
feat/themes/evergarden
branch
from
0eddf04 to
061ec3e
Compare
|
Thank you for the PR. As it is a UI change, it would have been nice to have a screenshot of the result. 
|
sorry that makes sense. i followed the changes in #12420 and that didnt have any screenshots so i forgot. heres a screenshot with the selection working properly and background opacity set to |
|
Beautiful color choice! I really like it :) |
|
hi. is there a way to help speed up merging this pr? I recently bought a retroid pocket 6 and id love to just use this on there. ❤️ |
4 participants
Description
hi i added the evergarden theme for ozone and rgui.
its a really nice darkgreen colorscheme!
everything seems to work alright for me but if there is any issues ill be quick to respond.
Related Issues
i added the theme after every instance of dracula to try to mimic some sense of alphabetical order in the code.
Related Pull Requests
#12268
#12420
libretro/retroarch-assets#493
Reviewers