Retroarch can't apply some valid ips patches #18774
Description
Is there an existing issue for this?
- This is a bug in RetroArch frontend
- I have searched the existing issues
Description
This hack
https://www.romhacking.net/hacks/1386/
Using the correct rom with the right crc, and the patch 'Final Fantasy VI (TWUE) + Bug Fixes, Updated Opera, & Add-Ons.ips'
Fails to apply at runtime with the softpatch feature of retroarch.
I know or heavily suspect this is a retroarch bug for two reasons:
If I apply the patch manually with flips it applies and runs. That is not surprising since this is a ips patch. But the surprising thing is if I use flips to create a ips patch from the original rom to the new rom, retroarch still can't load the resulting softpatch.
The second thing is that if I instead of creating a ips patch in the last step above I create a bps patch, retroarch loads it fine.
Retroarch support for ips patches is hitting some kind of bug because of these two factors: flips doesn't care, retroarch DOES care even about a latch recreation, and the same data turned into a bps patch makes it load the hack.
Expected behavior
No response
Steps to reproduce the bug
Download the patch extract 'Final Fantasy VI (TWUE) + Bug Fixes, Updated Opera, & Add-Ons.ips' and rename it to try to load no intro final fantasy iii (usa) rom with checksum a27f1c7a with retroarch softpatch support and a log (btw I think retroarch should message to the user failed softpatches)
Then use flips to create a hardpatch with that ROM and patch first (not the same filename) then create a bps patch from the original to the new rom, rename it to the original filename+bps, delete the ips patch and try to load it again in retroarch. Success.
Version/Commit
1.22.2
Bisect Results
No response
Present in the nightly version
I don't know
Platform & operating system
android 15
Affected Cores
No response
Environment information
No response