Skip to content

Conversation

@Elolcol
Copy link
Contributor

@Elolcol Elolcol commented Oct 16, 2025

Screenshot_20251016-005401.png

@Elolcol Elolcol changed the title Feat comments row, replies and sheet styles and layout feat: comments row, replies and sheet styles and layout Oct 16, 2025
@Bnyro
Copy link
Member

Bnyro commented Oct 16, 2025

I think it'd be better to keep the button background transparent and not make them filled, somehow this doesn't look really good in my opinion.

What's your opinion @FineFindus ?

Apart from that I very much like the other changes, thanks for the PR!

@Bnyro Bnyro requested a review from FineFindus October 16, 2025 12:53
Copy link
Collaborator

@FineFindus FineFindus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I think in general color should be used to nudge the user towards important actions available to them (e.g. the play button for a playlist) and neither the back button nor the close button is that important for the color.

@Bnyro Bnyro merged commit f0b3dd3 into libre-tube:master Oct 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants