Skip to content

Conversation

@Bnyro
Copy link
Member

@Bnyro Bnyro commented Oct 10, 2025

No description provided.

@Bnyro Bnyro merged commit 9429b3b into libre-tube:master Oct 10, 2025
3 checks passed
@FineFindus
Copy link
Collaborator

I feel like this might be another case of adding a confirmation dialog where an undo would be better. Or maybe we could just add the video to the current queue, if it's not already?

@Bnyro
Copy link
Member Author

Bnyro commented Oct 10, 2025

I think it makes sense to add a dialog here because it's easy to accidentially hit the "clear" button as it's in a row with many other similar looking buttons.

Or maybe we could just add the video to the current queue, if it's not already?

What do you mean by that? Currently we already keep the current video when clearing the queue.

@Bnyro
Copy link
Member Author

Bnyro commented Oct 10, 2025

The changes here only affect the playing queue sheet, probably should have mentioned that in the pr title

@Bnyro
Copy link
Member Author

Bnyro commented Oct 10, 2025

So #7740 is not really related, yeah :)

@FineFindus
Copy link
Collaborator

I think it makes sense to add a dialog here because it's easy to accidentally hit the "clear" button as it's in a row with many other similar looking buttons.

I don't disagree that it makes sense to prevent accidental taps, however having to confirm that users actually want to clear the queue every time is a bit overkill, don't you think? I feel like an undo options is much less intrusive whilst still fulfilling the same goal :)

What do you mean by that? Currently we already keep the current video when clearing the queue.

Sorry, got it mixed up.

So #7740 is not really related, yeah :)

Related in the sense that we discussed avoiding confirmation dialogs there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants