Skip to content

Conversation

@dhanuarf
Copy link
Contributor

@dhanuarf dhanuarf commented Oct 3, 2025

Also added snackbar to notify user.

Copy link
Collaborator

@FineFindus FineFindus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please split this into two different commits, as it's two different changes (this makes it easier to follow the history).

Also, I think

  • having a snackbar to show that a screenshot is being created isn't really necessary, as that is already obvious when the user is asked to choose a file and generally saving the file is relatively quick
  • we should use a toast here, instead of a snackbar, considering the user does not have any useful interaction, similar to how we show a toast when a SponsorBlock segment is skipped. Alternatively I'm also open to adding a share button to the snackbar.

@dhanuarf
Copy link
Contributor Author

dhanuarf commented Oct 6, 2025

  • having a snackbar to show that a screenshot is being created isn't really necessary, as that is already obvious when the user is asked to choose a file and generally saving the file is relatively quick

This depends on the quality and/or the content of what is being captured. PNG is quite costly when it comes to complex/detailed picture. It could take up to a few seconds depending on the device. I think it would be awkward if we only notify the user after it's succesfully saved, because the wait time could be several seconds.

But I'm fine removing it though.

  • we should use a toast here, instead of a snackbar, considering the user does not have any useful interaction, similar to how we show a toast when a SponsorBlock segment is skipped.

The reason I use snackbar is just to match the material design. Toast is displayed by the system framework, so different android version have different looks. So if we really follow the material design I think we need start to use snackbar from now on?

Alternatively I'm also open to adding a share button to the snackbar.

I think that's a great idea.

@dhanuarf dhanuarf force-pushed the snapio branch 2 times, most recently from 355b0c4 to 6b3aaae Compare October 7, 2025 09:59
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both, I agree that a share button justified adding the snackbar here 👍

Copy link
Collaborator

@FineFindus FineFindus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two more small nitpicks, but otherwise LGTM.

@FineFindus
Copy link
Collaborator

Thanks!

@FineFindus FineFindus merged commit 96bf073 into libre-tube:master Oct 9, 2025
4 checks passed
@dhanuarf dhanuarf deleted the snapio branch October 17, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants