Skip to content

fix: don't cancel subscriptions import if some channels can't be imported #7692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

fix: don't cancel subscriptions import if some channels can't be imported #7692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions app/src/main/java/com/github/libretube/repo/LocalSubscriptionsRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
package com.github.libretube.repo

import android.util.Log
import com.github.libretube.api.obj.Subscription
import com.github.libretube.db.DatabaseHolder.Database
import com.github.libretube.db.obj.LocalSubscription
import com.github.libretube.extensions.TAG
import com.github.libretube.extensions.parallelMap
import com.github.libretube.ui.dialogs.ShareDialog.Companion.YOUTUBE_FRONTEND_URL
import org.schabi.newpipe.extractor.channel.ChannelInfo
Expand Down Expand Up @@ -33,15 +35,26 @@ class LocalSubscriptionsRepository : SubscriptionsRepository {
val subscribedChannels = getSubscriptionChannelIds()

val newFiltered = newChannels.filter { !subscribedChannels.contains(it) }

val failedChannels = mutableListOf<String>()
for (chunk in newFiltered.chunked(CHANNEL_CHUNK_SIZE)) {
chunk.parallelMap { channelId ->
val channelUrl = "$YOUTUBE_FRONTEND_URL/channel/${channelId}"
val channelInfo = ChannelInfo.getInfo(channelUrl)
try {
val channelUrl = "$YOUTUBE_FRONTEND_URL/channel/${channelId}"
val channelInfo = ChannelInfo.getInfo(channelUrl)

val avatarUrl = channelInfo.avatars.maxByOrNull { it.height }?.url
subscribe(channelId, channelInfo.name, avatarUrl, channelInfo.isVerified)
val avatarUrl = channelInfo.avatars.maxByOrNull { it.height }?.url
subscribe(channelId, channelInfo.name, avatarUrl, channelInfo.isVerified)
} catch (e: Exception) {
Log.e(TAG(), e.toString())
failedChannels.add(channelId)
}
}
}

if (!failedChannels.isEmpty()) {
throw Exception("Failed to import ${failedChannels.joinToString(", ")}")
}
}

override suspend fun getSubscriptions(): List<Subscription> {
Expand Down
Loading