feat: show toolbar when scrolling up in subscriptions feed for better accessibility #7673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Perhaps the changes no longer really makes sense due to the subscriptions redesign with #7444? |
Contributor
Author
I think the part where the toolbar is shown when scrolling up (which is the main point of this PR) still makes sense. I can revert the other changes in the bullet points above. |
This comment was marked as outdated.
This comment was marked as outdated.
dhanuarf
force-pushed
the
expandtoolbarsubs
branch
from
e7a08d9 to
eafe53d
Compare
dhanuarf
force-pushed
the
expandtoolbarsubs
branch
from
eafe53d to
d130d42
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we dont need to scroll all the way up just to filter the list.
Other changes:- Toolbar stays expanded when the subscription list is opened. The reason I made it like this is because I think the subscription list is still part/menu of the toolbar, not an actual content of this fragment, so the toolbar should stay open with the list ( I think?)- Added collapse icon: