fix(player ui): seek and skip buttons appear at opposite side in rtl mode #7635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhanuarf
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
No, I was talking about when the device is in RTL mode |
Member
Perhaps we should keep it like that while there are no complaints because people probably already got used to it like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also notice the skip segment button appears at the left side in rtl mode. The video is progressing from left to right so the skip segment button on the left side seems kind of unintuitive, I think? I wanted to hardcode it on the right side but realized it's been there for quite some time so it might make some people unhappy if it's moved so I just left it untouched.