Skip to content

Conversation

@dhanuarf
Copy link
Contributor

@dhanuarf dhanuarf commented Aug 7, 2025

This PR fixes #7614

@dhanuarf dhanuarf force-pushed the fixpauseminimized branch from c1aa90b to b0e345a Compare August 7, 2025 10:31
Copy link
Collaborator

@FineFindus FineFindus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move (or integrate this) to the check below that already pauses the screen if the screen is off, to avoid having got sections (in slightly different places) that handle pausing the player.

// pause player if screen off and setting enabled
if (!isInteractive && PlayerHelper.pausePlayerOnScreenOffEnabled) {
playerController.pause()
}

@dhanuarf
Copy link
Contributor Author

dhanuarf commented Aug 7, 2025

Please move (or integrate this) to the check below that already pauses the screen if the screen is off, to avoid having got sections (in slightly different places) that handle pausing the player.

Would this be ok?

        val shouldPausePlayer =
            (isInteractive && PlayerHelper.pauseOnQuit) ||
                    (!isInteractive && PlayerHelper.pausePlayerOnScreenOffEnabled)

        if (shouldPausePlayer) {
            playerController.pause()
        }

@Bnyro Bnyro force-pushed the fixpauseminimized branch from b0e345a to dee2c69 Compare August 7, 2025 19:21
@Bnyro Bnyro merged commit b915b92 into libre-tube:master Aug 7, 2025
3 checks passed
@dhanuarf dhanuarf deleted the fixpauseminimized branch August 8, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimizing Setting Ignored When Switching Apps

3 participants