-
-
Notifications
You must be signed in to change notification settings - Fork 522
feat: separate 'clone' and 'create' when creating a new playist #7597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the spinner option to create a new playlist should be renamed to something like New private playlist? That probably makes it more clear, "Create playlist" is already in the title and thus we currently have the same text twice.
Yeah I was trying to avoid to create or modify any strings, so I just used whats available. |
6e4b03e to
0d2ceba
Compare
| binding.createPlaylistSpinner.items = listOf<String>( | ||
| getString(R.string.clonePlaylist), | ||
| getString(R.string.createNewPlaylist)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| binding.createPlaylistSpinner.items = listOf<String>( | |
| getString(R.string.clonePlaylist), | |
| getString(R.string.createNewPlaylist)) | |
| binding.createPlaylistSpinner.items = listOf<String>( | |
| getString(R.string.createNewPlaylist), | |
| getString(R.string.clonePlaylist) | |
| ) |
The default value should be the first item, not the second one. It feels a bit confusing otherwise.
d2fcaac to
238c385
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!

This PR separate
clone playlistandcreate playlistinto separate view via spinner.Having 2 options in the same UI while the user only able to proceed with just one of them is kind of bad UX, I think?
Before changes:

After changes:
