Skip to content

Conversation

@dhanuarf
Copy link
Contributor

@dhanuarf dhanuarf commented Aug 3, 2025

This PR separate clone playlist and create playlist into separate view via spinner.

Having 2 options in the same UI while the user only able to proceed with just one of them is kind of bad UX, I think?

Before changes:
before-pl-dialog-Screenshot_20250803-065659_LibreTube Debug

After changes:
After-pl-dialog-Screenshot_20250803-064904_LibreTube Debug

Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the spinner option to create a new playlist should be renamed to something like New private playlist? That probably makes it more clear, "Create playlist" is already in the title and thus we currently have the same text twice.

@dhanuarf
Copy link
Contributor Author

dhanuarf commented Aug 3, 2025

Perhaps the spinner option to create a new playlist should be renamed to something like New private playlist? That probably makes it more clear, "Create playlist" is already in the title and thus we currently have the same text twice.

Yeah I was trying to avoid to create or modify any strings, so I just used whats available.

@dhanuarf
Copy link
Contributor Author

dhanuarf commented Aug 3, 2025

c86f442:

Screenshot_20250803-175201_LibreTube Debug

Comment on lines 26 to 28
binding.createPlaylistSpinner.items = listOf<String>(
getString(R.string.clonePlaylist),
getString(R.string.createNewPlaylist))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
binding.createPlaylistSpinner.items = listOf<String>(
getString(R.string.clonePlaylist),
getString(R.string.createNewPlaylist))
binding.createPlaylistSpinner.items = listOf<String>(
getString(R.string.createNewPlaylist),
getString(R.string.clonePlaylist)
)

The default value should be the first item, not the second one. It feels a bit confusing otherwise.

@Bnyro Bnyro force-pushed the create-pl-dialog branch 2 times, most recently from d2fcaac to 238c385 Compare August 7, 2025 19:10
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Bnyro Bnyro force-pushed the create-pl-dialog branch from 238c385 to 0b0b2c9 Compare August 7, 2025 19:14
@Bnyro Bnyro merged commit 63aab01 into libre-tube:master Aug 7, 2025
3 checks passed
@dhanuarf dhanuarf deleted the create-pl-dialog branch August 8, 2025 01:36
@dhanuarf dhanuarf restored the create-pl-dialog branch August 8, 2025 02:40
@dhanuarf dhanuarf deleted the create-pl-dialog branch August 12, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants